Regularly broadcast node announcements #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnull
force-pushed
the
2023-04-broadcast-node-announcments
branch
4 times, most recently
from
5c35993 to
8f5a430
Compare
wpaulino
reviewed
May 16, 2023
tnull
force-pushed
the
2023-04-broadcast-node-announcments
branch
3 times, most recently
from
82a9d32 to
613053a
Compare
|
Rebased after #70 was merged. |
tnull
force-pushed
the
2023-04-broadcast-node-announcments
branch
from
613053a to
52d0839
Compare
tnull
force-pushed
the
2023-04-broadcast-node-announcments
branch
from
52d0839 to
f2bbf12
Compare
|
Do you mind extracting 7102ff4 into its own PR and rebasing this on top? It'll make reviewing this a bit more straight-forward. |
tnull
force-pushed
the
2023-04-broadcast-node-announcments
branch
from
f2bbf12 to
90ad5d1
Compare
tnull
force-pushed
the
2023-04-broadcast-node-announcments
branch
from
90ad5d1 to
b344c3f
Compare
Merged
tnull
force-pushed
the
2023-04-broadcast-node-announcments
branch
from
b344c3f to
45bfccf
Compare
tnull
force-pushed
the
2023-04-broadcast-node-announcments
branch
from
054646d to
ecb01df
Compare
|
Rebased after #104 landed and squashed the trivial fixup. |
We remember when we last broadcasted a node announcement and only re-announce if sufficient time has passed, we have at least one public channel, and we have some connected peers to gossip to.
tnull
force-pushed
the
2023-04-broadcast-node-announcments
branch
from
ecb01df to
d86aa1a
Compare
wpaulino
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48, Based on #104.