Revert "Cache the SDL_PixelFormatDetails in SDL2_PixelFormat::next" #545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7f7b1e6. Specifically, it reverts the handling of the pixel format passed to SDL3_ConvertSurfaceAndColorspace inside of SDL_ConvertSurface so that the pixel format is derived by calling SDL3_GetPixelFormatForMasks instead of using the value from format->format. Note, the other hunks from 7f7b1e6 were reverted in e47c7c7. Resolves: #542 Signed-off-by: Yodel Eldar <[email protected]>
Collaborator
|
This looks like the correct fix to me. SDL2 never looked at the pixel format so sdl2-compat shouldn't either. I added a comment explaining why this was done. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 7f7b1e6.
Specifically, it reverts the handling of the pixel format passed to SDL3_ConvertSurfaceAndColorspace inside of SDL_ConvertSurface so that the pixel format is derived by calling SDL3_GetPixelFormatForMasks instead of using the value from format->format.
Note, the other hunks from 7f7b1e6 were reverted in e47c7c7.
Resolves: #542