possible regression: Dwarf Fortress on Linux segfaults on invocation with 2.32.58

[Das-Nichts]

Hi,

after an update from 2.32.56 to 2.32.58 I’m not longer able to start Dwarf Fortress:

> LC_ALL=C ./run_df            
./run_df: line 4: 15206 Segmentation fault         (core dumped) LD_LIBRARY_PATH="${DF_DIR}:${LD_LIBRARY_PATH:+$LD_LIBRARY_PATH}" ./dwarfort "$@"

Stack trace can be found here: https://niemands.cloud/files/journal.txt

If any further information is needed, please let me know.

[yodel]

Commit 7f7b1e6 introduced the breaking change: Dwarf Fortress doesn't appear to populate the format field of the SDL2_PixelFormat pointer passed to SDL_ConvertSurface. Before the commit, the pixel format was derived by calling SDL3_GetPixelFormatForMasks in SDL_ConvertSurface, so users did not have to explicitly set the format themselves.

If users are required to set the format field (a reasonable ask IMO), then I could reach out to the DF team to let them know; if on the other hand the requirement was unintended, a partial revert of 7f7b1e6b6:SDL_ConvertSurface should fix the issue. I'd be happy to submit a patch for the partial revert in the latter case.

[slouken]

Sure, go ahead and submit a PR

[yodel]

Sure, go ahead and submit a PR

Thanks!