Raise error for a type mismatch in annassign #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please add a test for this error? |
certik
reviewed
Apr 14, 2022
| --> tests/errors/test_annassign_type_mismatch.py:4:5 | ||
| | | ||
| 4 | x: i32[4] = [1, 2, 3, 4] | ||
| | ^ ^^^^^^^^^^^^ type mismatch (integer and list) |
There was a problem hiding this comment.
So the type on the left is not just an integer, but an array of integers. So we should improve the error message to say it is an array.
There was a problem hiding this comment.
An idea what this can print is at #398 (comment), but that's longer term. As part of this PR or a next PR, we change just print it as:
4 | x: i32[4] = [1, 2, 3, 4]
| ^ ^^^^^^^^^^^^ type mismatch (i32[4] and list[i32])
We can do this by changing ASRUtils::type_to_str to ASRUtils::type_to_str_python and this function would print the type as i32[4].
There was a problem hiding this comment.
I'll open a new PR for that soon. Thanks. We definitely need excellent and self-explanatory error messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.