Merge pull request #370 from namannimmo10/annassign

Raise error for a type mismatch in annassign

Author: namannimmo10

src/lpython/semantics/python_ast_to_asr.cpp

@@ -1736,6 +1736,18 @@ class BodyVisitor : public CommonVisitor<BodyVisitor> {
             this->visit_expr(*x.m_value);
             value = ASRUtils::EXPR(tmp);
             value = cast_helper(type, value, true);
+            if (!ASRUtils::check_equal_type(type, ASRUtils::expr_type(value))) {
+                std::string ltype = ASRUtils::type_to_str(type);
+                std::string rtype = ASRUtils::type_to_str(ASRUtils::expr_type(value));
+                diag.add(diag::Diagnostic(
+                    "Type mismatch in annotation-assignment, the types must be compatible",
+                    diag::Level::Error, diag::Stage::Semantic, {
+                        diag::Label("type mismatch (" + ltype + " and " + rtype + ")",
+                                {x.m_target->base.loc, value->base.loc})
+                    })
+                );
+                throw SemanticAbort();
+            }
         }
         ASR::expr_t *init_expr = nullptr;
         ASR::intentType s_intent = ASRUtils::intent_local;

tests/errors/test_annassign_type_mismatch.py

@@ -0,0 +1,7 @@
+from ltypes import i32
+
+def f():
+    x: i32[4] = [1, 2, 3, 4]
+    print(a)
+
+f()

tests/reference/asr-test_annassign_type_mismatch-7dac7be.json

@@ -0,0 +1,13 @@
+{
+    "basename": "asr-test_annassign_type_mismatch-7dac7be",
+    "cmd": "lpython --show-asr --no-color {infile} -o {outfile}",
+    "infile": "tests/errors/test_annassign_type_mismatch.py",
+    "infile_hash": "5dacc11ffb3bc47fb14e508f454836ce4b196598d1943237cba9c86c",
+    "outfile": null,
+    "outfile_hash": null,
+    "stdout": null,
+    "stdout_hash": null,
+    "stderr": "asr-test_annassign_type_mismatch-7dac7be.stderr",
+    "stderr_hash": "26b687e0b4a187c139b077ec970580df391288fce1d13bde3770ce3b",
+    "returncode": 2
+}

tests/reference/asr-test_annassign_type_mismatch-7dac7be.stderr

@@ -0,0 +1,5 @@
+semantic error: Type mismatch in annotation-assignment, the types must be compatible
+ --> tests/errors/test_annassign_type_mismatch.py:4:5
+  |
+4 |     x: i32[4] = [1, 2, 3, 4]
+  |     ^           ^^^^^^^^^^^^ type mismatch (integer and list)

tests/tests.toml

@@ -283,6 +283,10 @@ asr = true
 filename = "errors/test_str_slicing.py"
 asr = true
 
+[[test]]
+filename = "errors/test_annassign_type_mismatch.py"
+asr = true
+
 [[test]]
 filename = "errors/test_append_type_mismatch.py"
 asr = true