Skip to content

Pass CompilerOptions as argument to python_ast_to_asr() #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 5, 2022
Merged

Pass CompilerOptions as argument to python_ast_to_asr() #1273

merged 2 commits into from
Nov 5, 2022

Conversation

ubaidsk
Copy link
Collaborator

@ubaidsk ubaidsk commented Nov 5, 2022

closes #1272

@ubaidsk ubaidsk changed the title Pass compiler options as argument Pass CompilerOptions as argument to python_ast_to_asr() Nov 5, 2022
@ubaidsk
Copy link
Collaborator Author

ubaidsk commented Nov 5, 2022

This is ready. Please possibly review and please share feedback.

@ubaidsk ubaidsk requested a review from certik November 5, 2022 13:16
czgdp1807
czgdp1807 approved these changes Nov 5, 2022
View reviewed changes
Copy link
Collaborator

@czgdp1807 czgdp1807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@certik's approval will be required for final merge.

@ubaidsk
Copy link
Collaborator Author

ubaidsk commented Nov 5, 2022

Thank you for the approval, @czgdp1807.

certik
certik approved these changes Nov 5, 2022
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this is good, thanks!

@certik certik merged commit 89e74c5 into lcompilers:main Nov 5, 2022
@ubaidsk
Copy link
Collaborator Author

ubaidsk commented Nov 5, 2022

Thank you for the approval and merging!

@ubaidsk ubaidsk deleted the pass_compiler_options_as_arg branch November 5, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

@czgdp1807 czgdp1807 czgdp1807 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pass CompilerOptions as argument to python_ast_to_asr()
3 participants
@ubaidsk @certik @czgdp1807