Merge config files using array_replace_recursive #757
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is actually not desirable. For example: Main Config: Env Config: You might intend to replace the entire array, but you will actually up with a 3 element array of "foo", "bar", and "baz. That is why configs are not recursively merged. It causes problems. |
|
I'm now using something similar in my old framework. Such situation didn't occur but I get the point. Thx for info! |
|
No problem. |
|
Just revisiting this. I was wrong before. This is now implemented. |
|
Cool, thanks! |
valorin
added a commit
to valorin/laravel-framework
that referenced
this pull request
Aug 23, 2014
Normal configs were cascading with array_replace_recursive(), which merged recursive arrays nicely, however Package configs were using array_merge(), which only merged the top-level arrays. This is inconsistent across the configuration handling, and is confusing for users trying to override specific package configuration. It looks like this fix was proposed in Issue laravel#757, but missed when the Issue laravel#1225 was proposed, considered a duplicate, and eventually merged.
gonzalom
pushed a commit
to Hydrane/tmp-laravel-framework
that referenced
this pull request
Oct 12, 2023
…-from-test-event-mock Add `dispatch` method as a mock to the Event Dispatcher in `TestCase`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably it's related with (#709).
Config merge was replacing nested arrays. This PR makes Config to replace only specified values.