Fixing cascade behaviour for package config. #5531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normal configs were cascading with array_replace_recursive(), which merged recursive arrays nicely, however Package configs were using array_merge(), which only merged the top-level arrays. This is inconsistent across the configuration handling, and is confusing for users trying to override specific package configuration. It looks like this fix was proposed in Issue laravel#757, but missed when the Issue laravel#1225 was proposed, considered a duplicate, and eventually merged.
taylorotwell
added a commit
that referenced
this pull request
Sep 8, 2014
Fixing cascade behaviour for package config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normal configs were cascading with array_replace_recursive(), which
merged recursive arrays nicely, however Package configs were using
array_merge(), which only merged the top-level arrays. This is
inconsistent across the configuration handling, and is confusing for
users trying to override specific package configuration.
It looks like this fix was proposed in Issue #757, but missed when the
Issue #1225 was proposed, considered a duplicate, and eventually
merged.