Skip to content

restrict valid github repo name in nginx config #8694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2025
+2 −2
Merged

restrict valid github repo name in nginx config #8694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/k8s-io/configmap-nginx.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ data:
return 200 'ok';
}

location ~ ^/(?<repo>[^/]*)(?<subpath>/.*)?$ {
location ~ ^/(?<repo>[A-Za-z0-9\-_\.]+)(?<subpath>/.*)?$ {
# $https is set to 'on' when connecting to nginx via HTTPS directly.
set $https_status $https;
if ($http_x_forwarded_proto = 'https') {
Expand Down Expand Up @@ -106,7 +106,7 @@ data:
listen 80;

# The ?! block is negative-lookahead to prevent `/repo/` from grouping into (`repo`, `/`) while `/repo/path` will still group as (`repo`, `/path`).
location ~ ^/(?<sig_repo>.*?)(?!/+$)(?<repo_subpath>/.*)?$ {
location ~ ^/(?<sig_repo>[A-Za-z0-9\-_\.]+)(?!/+$)(?<repo_subpath>/.*)?$ {
# $https is set to 'on' when connecting to nginx via HTTPS directly.
set $https_status $https;
if ($http_x_forwarded_proto = 'https') {
Expand Down