Skip to content

restrict valid github repo name in nginx config #8694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2025
Merged

restrict valid github repo name in nginx config #8694

merged 1 commit into from
Oct 27, 2025
+2 −2

Conversation

@BenTheElder
Copy link
Member

@BenTheElder BenTheElder commented Oct 24, 2025

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 24, 2025
@k8s-ci-robot k8s-ci-robot added area/apps Application management, code in apps/ sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Oct 24, 2025
@thockin
Copy link
Member

thockin commented Oct 24, 2025

LGTM

@ameukam
Copy link
Member

ameukam commented Oct 25, 2025

/lgtm
/hold
Will rollout out on Monday.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 25, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2025
xmudrii
xmudrii approved these changes Oct 27, 2025
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ameukam
Copy link
Member

ameukam commented Oct 27, 2025

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 27, 2025
@k8s-ci-robot k8s-ci-robot merged commit df062be into kubernetes:main Oct 27, 2025
3 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Oct 27, 2025
@ameukam
Copy link
Member

ameukam commented Oct 27, 2025

Failure of postsubmit:
https://prow.k8s.io/view/gs/kubernetes-ci-logs/logs/post-k8sio-deploy-app-k8s-io/1982839624044646400

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xmudrii xmudrii xmudrii approved these changes

@GenPage GenPage Awaiting requested review from GenPage

@michelle192837 michelle192837 Awaiting requested review from michelle192837

Assignees

@ameukam ameukam

@xmudrii xmudrii

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apps Application management, code in apps/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.35

Development

Successfully merging this pull request may close these issues.

5 participants

@BenTheElder @thockin @ameukam @k8s-ci-robot @xmudrii