-
Notifications
You must be signed in to change notification settings - Fork 179
test: kubectl-validate manifests in presubmit #1083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cc @robscott |
Apologies for the delay @chewong. This looks great. Just one small comment. Will pass back with a LGTM when thats updated. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chewong, kfswain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Ernest Wong <[email protected]>
Signed-off-by: Ernest Wong <[email protected]>
/lgtm |
* test: kubectl-validate manifests in presubmit Signed-off-by: Ernest Wong <[email protected]> * Address PR comments Signed-off-by: Ernest Wong <[email protected]> --------- Signed-off-by: Ernest Wong <[email protected]>
This PR adds manifest validation with
kubectl-validate
to ensure manifests used in docs are up-to-date.Fixes #679
Test output: