Address PR comments

Signed-off-by: Ernest Wong <[email protected]>

Author: chewong

Makefile

@@ -132,7 +132,7 @@ vet: ## Run go vet against code.
 	go vet ./...
 
 .PHONY: test
-test: manifests generate fmt vet envtest image-build ## Run tests.
+test: manifests generate fmt vet envtest image-build verify-crds ## Run tests.
 	CGO_ENABLED=1 KUBEBUILDER_ASSETS="$(shell $(ENVTEST) use $(ENVTEST_K8S_VERSION) --bin-dir $(LOCALBIN) -p path)" go test $$(go list ./... | grep -v /e2e | grep -v /conformance) -race -coverprofile cover.out
 
 .PHONY: test-unit
@@ -163,6 +163,10 @@ ci-lint: golangci-lint
 verify: vet fmt-verify manifests generate ci-lint verify-all
 	git --no-pager diff --exit-code config api client-go
 
+.PHONY: verify-crds
+verify-crds: kubectl-validate
+	hack/verify-manifests.sh
+
 # Run static analysis.
 .PHONY: verify-all
 verify-all:

hack/verify-manifests.sh

@@ -44,8 +44,6 @@ main() {
   fetch_crds "https://raw.githubusercontent.com/GoogleCloudPlatform/gke-gateway-api/refs/tags/${GKE_GATEWAY_API_VERSION}/config/crd/networking.gke.io_healthcheckpolicies.yaml"
   fetch_crds "https://raw.githubusercontent.com/istio/istio/refs/tags/${ISTIO_VERSION}/manifests/charts/base/files/crd-all.gen.yaml"
 
-  make kubectl-validate
-
   ${SCRIPT_ROOT}/bin/kubectl-validate "${TEMP_DIR}"
   ${SCRIPT_ROOT}/bin/kubectl-validate "${SCRIPT_ROOT}/config/manifests" --local-crds "${TEMP_DIR}"
 }