Skip to content

📖 add CAPO to cluster-api book #1661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2019
Merged

📖 add CAPO to cluster-api book #1661

merged 1 commit into from
Oct 29, 2019

Conversation

@sbueringer
Copy link
Member

@sbueringer sbueringer commented Oct 26, 2019

What this PR does / why we need it:
This PR adds CAPO to the ClusterAPI book.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 26, 2019
@sbueringer sbueringer mentioned this pull request Oct 26, 2019
Closed
6 tasks
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 26, 2019
@sbueringer
Copy link
Member Author

sbueringer commented Oct 26, 2019 •
edited
Loading

/hold

until the following PRs are merged:

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 26, 2019
@sbueringer
Copy link
Member Author

sbueringer commented Oct 26, 2019

/assign @chuckha

@vincepri
Copy link
Member

vincepri commented Oct 26, 2019

/assign
/milestone v0.2.x

@k8s-ci-robot k8s-ci-robot added this to the v0.2.x milestone Oct 26, 2019
@randomvariable
Copy link
Member

randomvariable commented Oct 28, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2019
vincepri
vincepri reviewed Oct 28, 2019
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise LGTM

docs/book/src/tasks/installation.md Outdated
1. **Kind**

{{#tabs name:"kind-cluster" tabs:"AWS,Docker,vSphere"}}
{{#tabs name:"kind-cluster" tabs:"AWS,Docker,vSphere,OpenStack"}}
Copy link
Member

@vincepri vincepri Oct 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that we're duplicating instructions for all except Docker? If so, we should probably collapse them into one

Copy link
Member Author

@sbueringer sbueringer Oct 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Done.

Copy link
Member

@randomvariable randomvariable Oct 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 28, 2019
@vincepri
Copy link
Member

vincepri commented Oct 28, 2019

@sbueringer Can you squash to 1 commit?

@sbueringer sbueringer force-pushed the add-capo-cluster-api-book branch from b5b8d99 to eb09899 Compare October 29, 2019 05:49
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2019
@sbueringer
Copy link
Member Author

sbueringer commented Oct 29, 2019

@sbueringer Can you squash to 1 commit?

Of course. Done

@sbueringer
Copy link
Member Author

sbueringer commented Oct 29, 2019

/hold cancel
PRs in k8s.io and CAPO have been merged

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2019
@randomvariable
Copy link
Member

randomvariable commented Oct 29, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2019
@randomvariable
Copy link
Member

randomvariable commented Oct 29, 2019

/approve

1 similar comment
@detiber
Copy link
Contributor

detiber commented Oct 29, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 29, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber, randomvariable, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2019
@k8s-ci-robot k8s-ci-robot merged commit 16f014f into kubernetes-sigs:master Oct 29, 2019
@sbueringer
Copy link
Member Author

sbueringer commented Oct 29, 2019

@detiber is it possible to get this published in https://cluster-api.sigs.k8s.io/user/quick-start.html?

@vincepri
Copy link
Member

vincepri commented Oct 29, 2019

@sbueringer The book is published from release-0.2, can you open a PR to backport this commit (cherry-pick)?

@sbueringer sbueringer mentioned this pull request Oct 29, 2019
Merged
@sbueringer
Copy link
Member Author

sbueringer commented Oct 29, 2019

@sbueringer The book is published from release-0.2, can you open a PR to backport this commit (cherry-pick)?

Yes, done > #1680

@sbueringer sbueringer deleted the add-capo-cluster-api-book branch October 29, 2019 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vincepri vincepri vincepri left review comments

@moshloop moshloop Awaiting requested review from moshloop

@randomvariable randomvariable Awaiting requested review from randomvariable

Assignees

@chuckha chuckha

@randomvariable randomvariable

@vincepri vincepri

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v0.2.x

Development

Successfully merging this pull request may close these issues.

6 participants

@sbueringer @vincepri @randomvariable @detiber @k8s-ci-robot @chuckha