Skip to content

Conversation

@sbueringer
Copy link
Member

Finalizes doc & examples for v0.2.0

See also #480

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 26, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 26, 2019
@jichenjc
Copy link
Contributor

generally looks good, don't have to time to go through this recently
so maybe let @prankul88 provide some feed back and let's merge this and evolute from there

@sbueringer
Copy link
Member Author

@prankul88 can you take another look and tell us if it's okay for you. So somebody else, e.g. @jichenjc can lgtm & approve for you

@prankul88
Copy link
Contributor

@sbueringer looks good to me.

@sbueringer
Copy link
Member Author

@sbueringer looks good to me.

Thx :)

@jichenjc Can you approve/lgtm the PR?

@jichenjc
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2019
@k8s-ci-robot k8s-ci-robot merged commit f22521f into kubernetes-sigs:master Oct 29, 2019
@sbueringer sbueringer deleted the finalize-doc-for-v0.2.0 branch March 13, 2020 13:36
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
* finalize doc & examples for v0.2.0

* review fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants