Skip to content

🏃 Add and fix shellcheck errors #1621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Oct 23, 2019
Merged

🏃 Add and fix shellcheck errors #1621

k8s-ci-robot merged 1 commit into from
Oct 23, 2019

Conversation

@ashish-amarnath
Copy link
Contributor

@ashish-amarnath ashish-amarnath commented Oct 18, 2019

Signed-off-by: Ashish Amarnath [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1551

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 18, 2019
ashish-amarnath
ashish-amarnath commented Oct 18, 2019
View reviewed changes
detiber
detiber reviewed Oct 18, 2019
View reviewed changes
ashish-amarnath
ashish-amarnath commented Oct 18, 2019
View reviewed changes
ashish-amarnath
ashish-amarnath commented Oct 18, 2019
View reviewed changes
@ashish-amarnath ashish-amarnath force-pushed the add-shellcheck branch 4 times, most recently from 5614a34 to 1dd6af3 Compare October 18, 2019 22:20
@ashish-amarnath
Copy link
Contributor Author

ashish-amarnath commented Oct 20, 2019

/test pull-cluster-api-test

@detiber
Copy link
Contributor

detiber commented Oct 21, 2019

/approve
/assign @chuckha

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 21, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashish-amarnath, detiber

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2019
vincepri
vincepri reviewed Oct 21, 2019
View reviewed changes
@vincepri vincepri added this to the v0.3.0 milestone Oct 21, 2019
@ashish-amarnath
Copy link
Contributor Author

ashish-amarnath commented Oct 21, 2019

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2019
@ashish-amarnath
Copy link
Contributor Author

ashish-amarnath commented Oct 21, 2019

This check should not run on darwin

@vincepri
Copy link
Member

vincepri commented Oct 21, 2019

Instead of excluding it on Mac, can you just not install shellcheck if it's present on path? And run it as usual otherwise?

@ashish-amarnath
Copy link
Contributor Author

ashish-amarnath commented Oct 21, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2019
@ashish-amarnath
Copy link
Contributor Author

ashish-amarnath commented Oct 21, 2019

I didn't exclude it on Mac. shellcheck for mac also works. So I made it download the binary for Mac.
Not sure why this was excluded earlier.

@vincepri
Copy link
Member

vincepri commented Oct 21, 2019

Let's avoid messing with folks' paths if it's not needed, if shellcheck is already available in path, we should skip the download imo

@detiber
Copy link
Contributor

detiber commented Oct 21, 2019

Let's avoid messing with folks' paths if it's not needed, if shellcheck is already available in path, we should skip the download imo

If that's the case, should we ensure that the existing shellcheck is >= the expected version?

@ashish-amarnath
Copy link
Contributor Author

ashish-amarnath commented Oct 21, 2019

shellcheck gets downloaded into a tmp dir that gets cleaned up, so we will not be messing w/ PATH. So we can give folks a consistent behavior locally and in ci.

@ashish-amarnath
Copy link
Contributor Author

ashish-amarnath commented Oct 21, 2019

https://github.com/kubernetes-sigs/cluster-api/pull/1621/files#diff-21849b598a2db215f292c1bd4620e454R32

chuckha
chuckha reviewed Oct 23, 2019
View reviewed changes
@chuckha
Copy link
Contributor

chuckha commented Oct 23, 2019

lgtm pending one wget issue. wget is not on os x by default.

@ashish-amarnath
🏃 Add and fix shellcheck errors
01585c2 
Signed-off-by: Ashish Amarnath <[email protected]>
@chuckha
Copy link
Contributor

chuckha commented Oct 23, 2019

that worked swimmingly. I'll lgtm when the tests pass.

@chuckha
Copy link
Contributor

chuckha commented Oct 23, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2019
@k8s-ci-robot k8s-ci-robot merged commit 4a097d8 into kubernetes-sigs:master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vincepri vincepri vincepri left review comments

+3 more reviewers

@ncdc ncdc ncdc left review comments

@chuckha chuckha chuckha left review comments

@detiber detiber detiber left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@chuckha chuckha

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v0.3.0

Development

Successfully merging this pull request may close these issues.

Add shellcheck to make verify

6 participants

@ashish-amarnath @detiber @k8s-ci-robot @vincepri @chuckha @ncdc