Add shellcheck to make verify

[vincepri]

As part of make verify target, we should also run shellcheck on all the scripts in this repository. An example is available in the CABPK repository https://github.com/kubernetes-sigs/cluster-api-bootstrap-provider-kubeadm/blob/master/hack/verify-shellcheck.sh

/kind feature
/help
/milestone v0.3.0
/priority important-longterm

[k8s-ci-robot]

@vincepri:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

As part of make verify target, we should also run shellcheck on all the scripts in this repository. An example is available in the CABPK repository https://github.com/kubernetes-sigs/cluster-api-bootstrap-provider-kubeadm/blob/master/hack/verify-shellcheck.sh

/kind feature
/help
/milestone v0.3.0
/priority important-longterm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[prankul88]

@vincepri Hi, Do you like the implementation where CABPK uses utils.sh for getting root path?

[ashish-amarnath]

/assign
/lifecycle active