Pr use existing networks #477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/L
Member
Author
|
/assign @jichenjc |
|
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
/uncc |
jichenjc
reviewed
Oct 8, 2019
| } | ||
| } else { | ||
| if openStackCluster.Status.Network == nil { | ||
| return nil, fmt.Errorf("no network was found in OpenStackCluster.Status.Network") |
Contributor
There was a problem hiding this comment.
maybe we need add some info that because the machine doesn't have network spec and cluster network is also nil
so we return error..
jichenjc
reviewed
Oct 10, 2019
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This was referenced Jan 4, 2020
pierreprinetti
pushed a commit
to shiftstack/cluster-api-provider-openstack
that referenced
this pull request
Apr 22, 2024
* use existing networks, fallback to network/subnet defined in cluster status * linter fixes * remove the network filters which are not required anymore * regen code/crds * review fixes * fix tests, by fixing kustomize * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ups, deleted the old branch so the old PR was closed. So again:
Okay I tested my existing multi-node setup and I tested it with remove networks filter. Both worked
@jichenjc Can you test if you're now able to use loadbalancers by setting the network and subnet fields (filters) in the ClusterSpec?
Edit: Old PR was this one: #475