Skip to content

Conversation

@sbueringer
Copy link
Member

This PR enables the following:

  • reuse existing networks/subnet if they cannot be created (by defining NodeCIDR in the OpenStackCluster)
  • define network/subnet on the cluster level so it doesn't has to be defined in every Machine (only works for one net/subnet not multiple)

Fixes #428

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2019
@sbueringer
Copy link
Member Author

/assign @jichenjc
/assign @hidekazuna
/hold

I didn't test it yet myself but I'm on it :)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2019
@sbueringer
Copy link
Member Author

Okay I tested my existing multi-node setup and I tested it with remove networks filter. Both worked

/hold cancel

@jichenjc Can you test if you're now able to use loadbalancers by setting the network and subnet fields (filters) in the ClusterSpec?

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2019
@sbueringer sbueringer closed this Oct 6, 2019
@sbueringer sbueringer deleted the pr-use-existing-networks branch October 6, 2019 12:08
@sbueringer sbueringer restored the pr-use-existing-networks branch October 6, 2019 12:10
@sbueringer
Copy link
Member Author

Was fixed in #477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support create LB with existing network/subnet

4 participants