Skip to content

fixed quotes in coreos userdata #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2019
Merged

fixed quotes in coreos userdata #441

merged 1 commit into from
Aug 16, 2019

Conversation

@sbueringer
Copy link
Member

@sbueringer sbueringer commented Aug 16, 2019

I diffed the CoreOS userdata in the repo against the one I'm using to test in my air-gaped environment and found a small issue :)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 16, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 16, 2019
@sbueringer
Copy link
Member Author

sbueringer commented Aug 16, 2019

/assign @jichenjc
/assign @hidekazuna

@hidekazuna
Copy link
Contributor

hidekazuna commented Aug 16, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2019
@jichenjc
Copy link
Contributor

jichenjc commented Aug 16, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 16, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2019
@k8s-ci-robot k8s-ci-robot merged commit 546152f into kubernetes-sigs:master Aug 16, 2019
@jichenjc jichenjc mentioned this pull request Aug 18, 2019
Merged
k8s-ci-robot pushed a commit that referenced this pull request Aug 18, 2019
@jichenjc @k8s-ci-robot
Backport changes from master to release-0.1 (#447)
bd74f23 
* Fix clouds.yaml link and add some notes (#440)

This commit fixes clouds.yaml link and some notes about cacert
in README.md

* fixed quotes in coreos userdata (#441)
prankul88 pushed a commit to prankul88/cluster-api-provider-openstack that referenced this pull request Sep 5, 2019
@sbueringer @prankul88
fixed quotes in coreos userdata (kubernetes-sigs#441)
2c0788d
@sbueringer sbueringer deleted the pr-minor-coreos-fixes branch October 6, 2019 12:09
@EmilienM EmilienM mentioned this pull request Jan 31, 2023
Closed
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
@sbueringer @pierreprinetti
fixed quotes in coreos userdata (kubernetes-sigs#441)
4e06362
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gyliu513 gyliu513 Awaiting requested review from gyliu513

@jichenjc jichenjc Awaiting requested review from jichenjc

Assignees

@hidekazuna hidekazuna

@jichenjc jichenjc

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sbueringer @hidekazuna @jichenjc @k8s-ci-robot