Skip to content

Conversation

@hidekazuna
Copy link
Contributor

What this PR does / why we need it:

This PR fixes clouds.yaml link and add some notes about cacert in README.md.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


This commit fixes clouds.yaml link and some notes about cacert
in README.md
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 16, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 16, 2019
@jichenjc
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hidekazuna, jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2019
@sbueringer
Copy link
Member

/lgtm

@jichenjc How does this work now with the branched away release-0.1. Because we didn't start with v1alpha2 we need all PRs for now on both branches right? And master would be the wrong one for v1alpha1 PRs as soon as we start work on v1alpha2

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2019
@sbueringer
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit a02a66c into kubernetes-sigs:master Aug 16, 2019
k8s-ci-robot pushed a commit that referenced this pull request Aug 18, 2019
* Fix clouds.yaml link and add some notes (#440)

This commit fixes clouds.yaml link and some notes about cacert
in README.md

* fixed quotes in coreos userdata (#441)
@hidekazuna hidekazuna deleted the cacert_doc branch February 17, 2020 04:36
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
This commit fixes clouds.yaml link and some notes about cacert
in README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants