🌱 Remove It block from clusterctl upgrade

[lentzi90]

What this PR does / why we need it:

The ClusterctlUpgradeSpec contains a BeforeEach block so it cannot be nested in an It block.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

• squashed commits
• if necessary:
  • includes documentation
  • adds unit tests

/hold

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name	Link
🔨 Latest commit	b2bdc35
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6396e30cecd696000ae8972f
😎 Deploy Preview	https://deploy-preview-1412--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[jichenjc]

/lgtm

[lentzi90]

/test pull-cluster-api-provider-openstack-e2e-full-test

[tobiasgiese]

@lentzi90 this is not possible, see PR description of #1406. The By block MUST be inside an It block and SetEnvVar has an By inside its function.
See also https://onsi.github.io/ginkgo/#documenting-complex-specs-by

[lentzi90]

@lentzi90 this is not possible, see PR description of #1406. The By block MUST be inside an It block and SetEnvVar has an By inside its function. See also https://onsi.github.io/ginkgo/#documenting-complex-specs-by

Oh now I understand. Unfortunately it is not possible to put the It there either. Maybe we can change SetEnvVar or find a different way to log things. 🤔

[tobiasgiese]

Maybe we can change SetEnvVar or find a different way to log things.

Also thought about the exact same thing. But for my PR it was the easiest to fix it by putting it into the It.
You could also workaround and set the envs directly via os.SetEnv with a comment why you have todo it this way.

[lentzi90]

/test pull-cluster-api-provider-openstack-e2e-full-test

[tobiasgiese]

Thanks for fixing this! :)

/lgtm

[tobiasgiese]

/hold cancel

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90, tobiasgiese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tobiasgiese]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tobiasgiese]

/hold

waiting for pull-cluster-api-provider-openstack-e2e-full-test

[lentzi90]

pull-cluster-api-provider-openstack-e2e-full-test passed 🎉
/hold cancel