🐛 Bump CAPI version to fix cert-manager URL #1169

lentzi90 · 2022-03-09T06:56:04Z

What this PR does / why we need it:

The e2e tests are broken for release-0.5. Probably due to the organization change for cert-manager. By bumping the CAPI version this should be fixed.
Ref. slack discussion.

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
This is my first PR to CAPO, please tell me if there is anything I missed.

TODOs:

squashed commits
if necessary:
- includes documentation
- adds unit tests

/hold

netlify · 2022-03-09T06:56:10Z

✔️ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

🔨 Explore the source changes: 41c1d6d

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/62288b5e3ef0fd000860bb3a

😎 Browse the preview: https://deploy-preview-1169--kubernetes-sigs-cluster-api-openstack.netlify.app

k8s-ci-robot · 2022-03-09T06:56:11Z

Welcome @lentzi90!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2022-03-09T06:56:12Z

Hi @lentzi90. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

chrischdi · 2022-03-09T07:16:19Z

/ok-to-test

chrischdi · 2022-03-09T08:43:07Z

Original fix was this one: https://github.com/kubernetes-sigs/cluster-api/pull/6050/files

Fix on capo main was this one: #1136

So I was wrong with the requirement to bump sigs.k8s.io/cluster-api/test , sigs.k8s.io/cluster-api needs to be updated but this is also done in your PR 👍

lentzi90 · 2022-03-09T08:49:21Z

Original fix was this one: https://github.com/kubernetes-sigs/cluster-api/pull/6050/files

So I was wrong with the requirement to bump sigs.k8s.io/cluster-api/test , sigs.k8s.io/cluster-api needs to be updated but this is also done in your PR +1

Yeah I realized when the test failed that I needed to also update CAPI, not just the test. I guess this is because the error is coming from clusterctl, which is in CAPI (not part of the test package). Hoping it will pass this time 🤞
Do you want me to remove the bump for CAPI/test or is it better to bump both so they are at the same version?

chrischdi · 2022-03-09T08:50:47Z

I think they should be in sync so lets see how the test goes now 👍

Forgot to add prior to this: thank you for tackling this and the contribution 🎉

lentzi90 · 2022-03-09T09:37:58Z

Hmm now I'm a bit lost. Still the same error. 🤔

mdbooth · 2022-03-09T10:15:08Z

See #1133 which I kind of abandoned when it seemed we weren't going to use it. You'll need to bump the versions in test/e2e/data/e2e_conf.yaml too at a minimum.

mdbooth · 2022-03-09T10:17:09Z

Although you might need to bump them to 1.0.5 rather than 1.0.4, which my older patch did. Note that my PR wasn't working yet.

lentzi90 · 2022-03-09T10:22:40Z

Thanks @mdbooth ! I realized there was a replace in the go.mod that still had the old version also. Now hopefully everything is updated.

chrischdi · 2022-03-09T10:38:04Z

Yes, the old test did still ues the old version, visible in the logs via: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-openstack/1169/pull-cluster-api-provider-openstack-e2e-test/1501477514122366976#1:build-log.txt%3A1485:

...
go: downloading k8s.io/utils v0.0.0-20210930125809-cb0fa318a74b
go: downloading sigs.k8s.io/cluster-api v1.0.1-0.20211028151834-d72fd59c8483
go: downloading sigs.k8s.io/cluster-api/test v1.0.5
go: downloading sigs.k8s.io/controller-runtime v0.10.3
go: downloading github.com/gogo/protobuf v1.3.2
...

🤞

lentzi90 · 2022-03-09T11:11:52Z

Missed some references in the Makefile also.

chrischdi · 2022-03-09T12:42:13Z

Green tests 🎉

/lgtm

mdbooth · 2022-03-09T13:08:29Z

We should probably fix OWNERS in the 0.5 branch if we're going to keep maintaining it.

/assign @jichenjc

seanschneeweiss

/lgtm

lentzi90 · 2022-03-09T13:56:15Z

/hold cancel

sbueringer · 2022-03-09T16:10:29Z

lending an approve until the other PR is merged :)
/approve

k8s-ci-robot · 2022-03-09T16:10:41Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90, mdbooth, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jichenjc · 2022-03-10T00:55:59Z

We should probably fix OWNERS in the 0.5 branch if we're going to keep maintaining it.

do you mind add corresponding approvers through PR then we can update it ? Thanks @mdbooth

sbueringer · 2022-03-10T05:53:19Z

@jichenjc I think that was done in: #1170

jichenjc · 2022-03-10T06:18:16Z

@sbueringer thanks :)

k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 9, 2022

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 9, 2022

k8s-ci-robot requested review from jichenjc and sbueringer March 9, 2022 06:56

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 9, 2022

lentzi90 force-pushed the lentzi90/fix-release-0.5-tests branch from 74c4dcf to b74fb5f Compare March 9, 2022 07:00

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 9, 2022

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 9, 2022

lentzi90 force-pushed the lentzi90/fix-release-0.5-tests branch from b74fb5f to 46093c6 Compare March 9, 2022 08:38

lentzi90 changed the title ~~🐛 Bump CAPI test framework~~ 🐛 Bump CAPI version to fix cert-manager URL Mar 9, 2022

lentzi90 force-pushed the lentzi90/fix-release-0.5-tests branch from 46093c6 to f43d67e Compare March 9, 2022 10:15

mdbooth mentioned this pull request Mar 9, 2022

🐛 Bump CAPI to v1.0.4 #1133

Closed

lentzi90 force-pushed the lentzi90/fix-release-0.5-tests branch from f43d67e to acf98d3 Compare March 9, 2022 10:20

lentzi90 force-pushed the lentzi90/fix-release-0.5-tests branch from acf98d3 to 41c1d6d Compare March 9, 2022 11:11

Bump CAPI version to fix cert-manager installation

41c1d6d

k8s-ci-robot assigned chrischdi Mar 9, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2022

mdbooth approved these changes Mar 9, 2022

View reviewed changes

k8s-ci-robot assigned jichenjc Mar 9, 2022

seanschneeweiss reviewed Mar 9, 2022

View reviewed changes

k8s-ci-robot assigned seanschneeweiss Mar 9, 2022

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 9, 2022

chrischdi mentioned this pull request Mar 9, 2022

🏃 sync OWNERS and OWNERS_ALIASES for v0.5 release branch #1170

Merged

2 tasks

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2022

k8s-ci-robot merged commit 455c285 into kubernetes-sigs:release-0.5 Mar 9, 2022

lentzi90 deleted the lentzi90/fix-release-0.5-tests branch March 9, 2022 18:48

apricote mentioned this pull request Mar 11, 2022

🐛 Delete trunk on failure #1130

Merged

🐛 Bump CAPI version to fix cert-manager URL #1169

🐛 Bump CAPI version to fix cert-manager URL #1169

Uh oh!

Conversation

lentzi90 commented Mar 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Mar 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Mar 9, 2022

Uh oh!

k8s-ci-robot commented Mar 9, 2022

Uh oh!

chrischdi commented Mar 9, 2022

Uh oh!

chrischdi commented Mar 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lentzi90 commented Mar 9, 2022

Uh oh!

chrischdi commented Mar 9, 2022

Uh oh!

lentzi90 commented Mar 9, 2022

Uh oh!

mdbooth commented Mar 9, 2022

Uh oh!

mdbooth commented Mar 9, 2022

Uh oh!

lentzi90 commented Mar 9, 2022

Uh oh!

chrischdi commented Mar 9, 2022

Uh oh!

lentzi90 commented Mar 9, 2022

Uh oh!

chrischdi commented Mar 9, 2022

Uh oh!

mdbooth commented Mar 9, 2022

Uh oh!

seanschneeweiss left a comment

Choose a reason for hiding this comment

Uh oh!

lentzi90 commented Mar 9, 2022

Uh oh!

sbueringer commented Mar 9, 2022

Uh oh!

k8s-ci-robot commented Mar 9, 2022

Uh oh!

jichenjc commented Mar 10, 2022

Uh oh!

sbueringer commented Mar 10, 2022

Uh oh!

jichenjc commented Mar 10, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

lentzi90 commented Mar 9, 2022 •

edited

Loading

netlify bot commented Mar 9, 2022 •

edited

Loading

chrischdi commented Mar 9, 2022 •

edited

Loading