Skip to content

Conversation

@mdbooth
Copy link
Contributor

@mdbooth mdbooth commented Feb 7, 2022

This fixes an issue preventing CI running against release-0.5.

Fixes #1132

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 7, 2022
@netlify
Copy link

netlify bot commented Feb 7, 2022

✔️ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

🔨 Explore the source changes: c073ea9

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/62026f88669f8a000755668e

😎 Browse the preview: https://deploy-preview-1133--kubernetes-sigs-cluster-api-openstack.netlify.app

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 7, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mdbooth
To complete the pull request process, please assign hidekazuna after the PR has been reviewed.
You can assign the PR to them by writing /assign @hidekazuna in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@apricote
Copy link
Member

apricote commented Feb 7, 2022

I think this upgrade is also needed in main to fix the same issue. In that case it might be cleaner to upgrade in main first, and then backport the fix to release-0.5

@mdbooth mdbooth force-pushed the release-0.5-capi-bump branch from 0569638 to e20dc51 Compare February 7, 2022 17:45
@mdbooth
Copy link
Contributor Author

mdbooth commented Feb 8, 2022

I think this upgrade is also needed in main to fix the same issue. In that case it might be cleaner to upgrade in main first, and then backport the fix to release-0.5

Thanks! I hadn't even thought to look if main was also affected 🤦‍♂️

sigs.k8s.io/controller-runtime v0.10.3
sigs.k8s.io/yaml v1.3.0
)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one line below should be changed too

@mdbooth mdbooth force-pushed the release-0.5-capi-bump branch from e20dc51 to c073ea9 Compare February 8, 2022 13:26
@mdbooth
Copy link
Contributor Author

mdbooth commented Feb 8, 2022

/test pull-cluster-api-provider-openstack-e2e-test

@chrischdi
Copy link
Member

I think this upgrade is also needed in main to fix the same issue. In that case it might be cleaner to upgrade in main first, and then backport the fix to release-0.5

for reference: looks like it was bumped on main via: #1137 :-)

/lgtm

CI issue looks unrelated:

/test pull-cluster-api-provider-openstack-e2e-test

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2022
@k8s-ci-robot
Copy link
Contributor

@mdbooth: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-openstack-e2e-test c073ea9 link true /test pull-cluster-api-provider-openstack-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mdbooth
Copy link
Contributor Author

mdbooth commented Mar 9, 2022

Closed in favour of #1169

@mdbooth mdbooth closed this Mar 9, 2022
@mdbooth mdbooth deleted the release-0.5-capi-bump branch December 13, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants