Skip to content

[release-2.2] [E2E] Fix E2E pipeline failures #4558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2023
Merged

[release-2.2] [E2E] Fix E2E pipeline failures #4558

merged 1 commit into from
Oct 13, 2023

Conversation

Ankitasw
Copy link
Member

@Ankitasw Ankitasw commented Oct 10, 2023 •
edited
Loading

What type of PR is this?
/kind failing-test
/kind support

What this PR does / why we need it:
This PR adds python3-requests package installation which is breaking right now in the pip installation in CI.
It also fixes the semantic version of latest aws infrastructure provider.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4550

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/support Categorizes issue or PR as a support question. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 10, 2023
@Ankitasw Ankitasw added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 10, 2023
@Ankitasw
Copy link
Member Author

/retest

@Ankitasw Ankitasw force-pushed the fix-metadata branch 2 times, most recently from 2cf7c76 to 9711de1 Compare October 10, 2023 07:15
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 10, 2023
@Ankitasw Ankitasw changed the title [release-2.2] [E2E] Fix aws provider version [release-2.2] [E2E] Fix E2E pipeline failures Oct 10, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 10, 2023
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 10, 2023
@Ankitasw
Copy link
Member Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@Ankitasw: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-aws-build
  • /test pull-cluster-api-provider-aws-build-release-2-2
  • /test pull-cluster-api-provider-aws-e2e-blocking-release-2-2
  • /test pull-cluster-api-provider-aws-test-release-2-2
  • /test pull-cluster-api-provider-aws-verify-release-2-2

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-aws-apidiff-release-2-2
  • /test pull-cluster-api-provider-aws-e2e-conformance-release-2-2
  • /test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts-release-2-2
  • /test pull-cluster-api-provider-aws-e2e-eks-release-2-2
  • /test pull-cluster-api-provider-aws-e2e-release-2-2

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-aws-apidiff-release-2-2
  • pull-cluster-api-provider-aws-build
  • pull-cluster-api-provider-aws-build-release-2-2
  • pull-cluster-api-provider-aws-e2e-blocking-release-2-2
  • pull-cluster-api-provider-aws-test-release-2-2
  • pull-cluster-api-provider-aws-verify-release-2-2

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Ankitasw
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e-conformance-release-2-2

@richardcase
Copy link
Member

@Ankitasw - how come --break-system-packages is needed?

@Ankitasw
Copy link
Member Author

It was a guess work based on the error message

note: If you believe this is a mistake, please contact your Python installation or OS distribution provider. You can override this, at the risk of breaking your Python installation or OS, by passing --break-system-packages.

Fix given in #4564 makes more sense to me, I will change it.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 11, 2023
@richardcase
Copy link
Member

/test pull-cluster-api-provider-aws-e2e-conformance-release-2-2

Ankitasw
Ankitasw commented Oct 11, 2023
View reviewed changes
test/e2e/data/e2e_conf.yaml
- sourcePath: "./shared/v1beta1_provider/metadata.yaml"
- sourcePath: "./infrastructure-aws/capi-upgrades/v1beta1/cluster-template.yaml"
- name: v2.0.99
- name: v2.2.99
Copy link
Member Author

@Ankitasw Ankitasw Oct 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richardcase I am also not sure why this works and not 2.0.99, this was also trial from my end. The test suites are not able to find the semantic version 2.0.99, but in main branch that works.

@Ankitasw
Copy link
Member Author

cc @Skarlso @richardcase to take a final look

@Skarlso
Copy link
Contributor

Skarlso commented Oct 13, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Skarlso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit cbfda4a into kubernetes-sigs:release-2.2 Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AverageMarcus AverageMarcus Awaiting requested review from AverageMarcus

@Skarlso Skarlso Awaiting requested review from Skarlso

Assignees

@Skarlso Skarlso

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/support Categorizes issue or PR as a support question. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Ankitasw @k8s-ci-robot @richardcase @Skarlso