Align logging practices with cluster-api

[Skarlso]

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3626

Special notes for your reviewer:

Checklist:

• squashed commits
• includes documentation
• adds unit tests
• adds or updates e2e tests

[Skarlso]

Hmmm, not sure if I'm done yet. CAPA does already some nice logging practices such as using ctx logger in reconcile loops.

But I feel like I'm missing something still... I will look at V(n) logs as well later on.

[Ankitasw]

This looks good 👍
@Skarlso V(n) logging is also not consistent, so I think we can handle that as part of this PR.
Wdyt?

[Skarlso]

@Ankitasw True. It might warrant a separate PR to handle V(n) log numbers. :)

[Ankitasw]

Ok, makes sense.
I think this issue is covering V(n) logging consistency part.

[Ankitasw]

/lgtm

[sedefsavas]

There are few other changes done in CAPV like using "sigs.k8s.io/controller-runtime instead of "sigs.k8s.io/controller-runtime/pkg/log".

kubernetes-sigs/cluster-api-provider-vsphere@df945ea

Also, does this PR cover the https://cluster-api.sigs.k8s.io/developer/providers/v1.1-to-v1.2.html logging section, there are bunch of changes in main in this doc.

/hold
until #3720 is merged.

[Skarlso]

Ah, thanks, @sedefsavas!

I shall take a look and incorporate those changes. :)

[Skarlso]

I don't think this was ever working before properly. :D
This was trying to use the package local variable but created a new one instead.

[Skarlso]

I0913 09:56:33.117909     373 addons.go:164] "describe output" output=<
	{
	  AddonArn: "arn:aws:eks:eu-central-1:<NOPE>addon/default_managed-cluster-control-plane/vpc-cni/aac19b19-02bc-2d31-5eee-b48ef0cfe5ce",
	  AddonName: "vpc-cni",
	  AddonVersion: "v1.11.0-eksbuild.1",
	  ClusterName: "default_managed-cluster-control-plane",
	  CreatedAt: 2022-09-13 09:33:11.631 +0000 UTC,
	  Health: {
	    Issues: []
	  },
	  ModifiedAt: 2022-09-13 09:33:12.697 +0000 UTC,
	  Status: "ACTIVE",
	  Tags: {
	    kubernetes.io/cluster/managed-cluster: "owned"
	  }
	}
 >
I0913 09:56:33.119742     373 addons.go:95] "Reconcile EKS addons completed successfully"
I0913 09:56:33.119784     373 identity_provider.go:33] "reconciling oidc identity provider"
I0913 09:56:33.119814     373 eks.go:64] "Reconcile EKS control plane completed successfully"
I0913 09:56:33.119846     373 cni.go:45] "Reconciling aws-node DaemonSet in cluster" cluster="default/managed-cluster"
I0913 09:56:33.120667     373 recorder.go:103] "events: Normal" object={Kind:AWSManagedControlPlane Namespace:default Name:managed-cluster-control-plane UID:2fa136ba-67ff-4b1d-9d4f-0e375b6b7fa7 APIVersion:controlplane.cluster.x-k8s.io/v1beta1 ResourceVersion:12502 FieldPath:} reason="SuccessfulReconcileEKSClusterAddons" message="Reconciled addons for EKS Cluster default_managed-cluster-control-plane"
I0913 09:56:33.121198     373 recorder.go:103] "events: Normal" object={Kind:AWSManagedControlPlane Namespace:default Name:managed-cluster-control-plane UID:2fa136ba-67ff-4b1d-9d4f-0e375b6b7fa7 APIVersion:controlplane.cluster.x-k8s.io/v1beta1 ResourceVersion:12502 FieldPath:} reason="SuccessfulReconcileEKSClusterAddons" message="Reconciled addons for EKS Cluster default_managed-cluster-control-plane"
I0913 09:56:33.777756     373 reconcile.go:39] "Reconciling kube-proxy DaemonSet in cluster" cluster="default/managed-cluster"
I0913 09:56:33.903582     373 reconcile.go:34] "Reconciling aws-iam-authenticator configuration" cluster="default/managed-cluster"
I0913 09:56:34.859719     373 reconcile.go:60] "Mapping node IAM role" iam-role="arn:aws:iam::542654844075:role/nodes.cluster-api-provider-aws.sigs.k8s.io" user="system:node:{{EC2PrivateDNSName}}"
I0913 09:56:34.891112     373 reconcile.go:65] "Mapping additional IAM roles and users"
I0913 09:56:34.891191     373 reconcile.go:81] "Reconciled aws-iam-authenticator configuration" cluster-name="default_managed-cluster-control-plane"

Logs are looking good. :)

[sedefsavas]

/hold cancel

[Skarlso]

Oh Gods.... :D

Turned out to be simple. :)

[sedefsavas]

/approve

[richardcase]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase, sedefsavas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [richardcase,sedefsavas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment