Skip to content

feat: Add a parameter to the GenericClient class that configures the … #1274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2023
Merged

feat: Add a parameter to the GenericClient class that configures the … #1274

merged 1 commit into from
Apr 24, 2023

Conversation

@IvanJosipovic
Copy link
Contributor

@IvanJosipovic IvanJosipovic commented Apr 20, 2023

Fixes #1273

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@729b10c). Click here to learn what that means.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##             master    #1274   +/-   ##
=========================================
  Coverage          ?   69.91%           
=========================================
  Files             ?       95           
  Lines             ?     2692           
  Branches          ?        0           
=========================================
  Hits              ?     1882           
  Misses            ?      810           
  Partials          ?        0

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

tg123
tg123 approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@tg123 tg123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IvanJosipovic, tg123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5e88155 into kubernetes-client:master Apr 24, 2023
This was referenced Sep 17, 2025
Closed
Open
Closed
Open
@dependabot dependabot bot mentioned this pull request Oct 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tg123 tg123 tg123 approved these changes

@brendandburns brendandburns Awaiting requested review from brendandburns

Assignees

@tg123 tg123

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GenericClient shouldn't dispose underlying client

4 participants

@IvanJosipovic @codecov-commenter @k8s-ci-robot @tg123