Skip to content

feat: Add a parameter to the GenericClient class that configures the … #1274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2023
Merged

feat: Add a parameter to the GenericClient class that configures the … #1274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/KubernetesClient/GenericClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,24 +11,26 @@ public class GenericClient : IDisposable
private readonly string group;
private readonly string version;
private readonly string plural;
private readonly bool disposeClient;

[Obsolete]
public GenericClient(KubernetesClientConfiguration config, string group, string version, string plural)
: this(new Kubernetes(config), group, version, plural)
{
}

public GenericClient(IKubernetes kubernetes, string version, string plural)
: this(kubernetes, "", version, plural)
public GenericClient(IKubernetes kubernetes, string version, string plural, bool disposeClient = true)
: this(kubernetes, "", version, plural, disposeClient)
{
}

public GenericClient(IKubernetes kubernetes, string group, string version, string plural)
public GenericClient(IKubernetes kubernetes, string group, string version, string plural, bool disposeClient = true)
{
this.group = group;
this.version = version;
this.plural = plural;
this.kubernetes = kubernetes;
this.disposeClient = disposeClient;
}

public async Task<T> CreateAsync<T>(T obj, CancellationToken cancel = default)
Expand Down Expand Up @@ -151,7 +153,10 @@ public void Dispose()

protected virtual void Dispose(bool disposing)
{
kubernetes.Dispose();
if (disposeClient)
{
kubernetes.Dispose();
}
}
}
}