Skip to content

feat(Escrow): add contract #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
30 commits merged into from
Dec 7, 2023
Merged

feat(Escrow): add contract #1330

30 commits merged into from
Dec 7, 2023

Conversation

unknownunknown1
Copy link
Contributor

@unknownunknown1 unknownunknown1 commented Nov 15, 2023

Initially I planned to base this contract on the newest version of Escrow but ultimately switched it to the earliest version that we also have deployed https://github.com/kleros/kleros-interaction/blob/master/contracts/standard/arbitration/MultipleArbitrableTransaction.sol
The newest version had some additional features (settlement proposal, platform fees) and gas optimizations that added complexity so I had to remove those.
Also note that this is the most basic version of escrow that uses native currency as payment. There is also another version that uses tokens instead.


PR-Codex overview

This PR introduces the Escrow contract, which is a multiple arbitrable transaction contract compatible with V2.

Detailed summary:

  • Added the Escrow contract.
  • Added enums and structs for parties, status, and resolution.
  • Added storage variables.
  • Added events for payment, fee payment, and transaction creation/resolution.
  • Added function modifiers.
  • Added constructor and governance functions.
  • Added state modifiers for creating transactions, making payments, and executing transactions.
  • Added functions for paying arbitration fees.
  • Added comments for clarity.

The following files were skipped due to too many changes: contracts/src/arbitration/arbitrables/Escrow.sol

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for kleros-v2 ready!

Name Link
🔨 Latest commit 721ab5c
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/6571c99d5539d50008235146
😎 Deploy Preview https://deploy-preview-1330--kleros-v2.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

kemuru and others added 20 commits November 16, 2023 12:43
…-and-pagination-overflow

fix(web)/cases-in-progress-and-pagination-overflow
…ry-results

fix(web): increased draw query results up to 1000
…-overview

refactor(web): case details overview file too big
…mponent-refactor

Refactor(web)/top juror component refactor
Copy link

codeclimate bot commented Dec 7, 2023

Code Climate has analyzed commit 721ab5c and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarqubecloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jaybuidl jaybuidl linked an issue Dec 7, 2023 that may be closed by this pull request
2 tasks
@jaybuidl jaybuidl closed this pull request by merging all changes into kleros:dev in 4c4a17e Dec 7, 2023
@jaybuidl jaybuidl linked an issue Dec 7, 2023 that may be closed by this pull request
@jaybuidl jaybuidl removed a link to an issue Dec 7, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Escrow v2 contract for ETH payment, no fee
5 participants