-
Notifications
You must be signed in to change notification settings - Fork 49
feat(Escrow): add contract #1330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kleros-v2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…-and-pagination-overflow fix(web)/cases-in-progress-and-pagination-overflow
…ry-results fix(web): increased draw query results up to 1000
…-overview refactor(web): case details overview file too big
…mponent-refactor Refactor(web)/top juror component refactor
…-fixes fix(subgraph): casting-fixes
Code Climate has analyzed commit 721ab5c and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! |
jaybuidl
approved these changes
Dec 7, 2023
jaybuidl
approved these changes
Dec 7, 2023
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially I planned to base this contract on the newest version of Escrow but ultimately switched it to the earliest version that we also have deployed https://github.com/kleros/kleros-interaction/blob/master/contracts/standard/arbitration/MultipleArbitrableTransaction.sol
The newest version had some additional features (settlement proposal, platform fees) and gas optimizations that added complexity so I had to remove those.
Also note that this is the most basic version of escrow that uses native currency as payment. There is also another version that uses tokens instead.
PR-Codex overview
This PR introduces the Escrow contract, which is a multiple arbitrable transaction contract compatible with V2.
Detailed summary: