Skip to content

fix(subgraph): casting-fixes #1345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Conversation

tractorss
Copy link
Contributor

@tractorss tractorss commented Dec 1, 2023

  1. Kleros core

    • appears when Execute function is called and TokenAndEthShift event is fired.
    • stack :-handleTokenAndETHShift -> updatePenalty -> entities/Penalty.ts/line-9, jurorAddress not being casted to
      HexString, fixed that
  2. Dispute Template

    • _templateTag is a indexed string , so it is being hashed(keccak256)
    • when handling in handleDisputeTemplate , toString is being used instead of toHexString(since it's a hash) to convert
      _templateTag

Cross checked the weird characters for both the subgraphs and confirmed the above.

For cross checking, these are the event logs https://goerli.arbiscan.io/tx/0x0f2b2c6a2b145f5e8889a262db0a3fb2ebb72566f924746d6a3819ff6e2380ac#eventlog
that were triggering the code and resulting in warnings


PR-Codex overview

Detailed summary

  • The focus of this PR is to update the code to use the toHexString() method when assigning values to jurorAddress and disputeTemplate.templateTag variables.
  • This PR also updates the disputeTemplate.templateDataMappings variable to be assigned as a string value.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

netlify bot commented Dec 1, 2023

Deploy Preview for kleros-v2 ready!

Name Link
🔨 Latest commit 4b73dd6
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/6569a2cc514e980008ac2055
😎 Deploy Preview https://deploy-preview-1345--kleros-v2.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Code Climate has analyzed commit 4b73dd6 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@alcercu alcercu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alcercu alcercu added this pull request to the merge queue Dec 1, 2023
Merged via the queue into dev with commit 2912f25 Dec 1, 2023
@jaybuidl jaybuidl deleted the fix(subgraph)/type-casting-fixes branch December 7, 2023 18:53
@jaybuidl jaybuidl added this to the testnet-3 milestone Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants