Refactor(web)/top juror component refactor #1343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kleros-v2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alcercu
requested changes
Nov 28, 2023
Comment on lines
9
to
24
| display: flex; | ||
| justify-content: space-between; | ||
| width: 100%; | ||
| background-color: ${({ theme }) => theme.lightBlue}; | ||
| padding: 24px; | ||
| border 1px solid ${({ theme }) => theme.stroke}; | ||
| border-top-left-radius: 3px; | ||
| border-top-right-radius: 3px; | ||
| border-bottom: none; | ||
| flex-wrap: wrap; | ||
| ${landscapeStyle( | ||
| () => | ||
| css` | ||
| display: none; | ||
| ` | ||
| )} |
There was a problem hiding this comment.
Missing identation
Suggested change
| display: flex; | |
| justify-content: space-between; | |
| width: 100%; | |
| background-color: ${({ theme }) => theme.lightBlue}; | |
| padding: 24px; | |
| border 1px solid ${({ theme }) => theme.stroke}; | |
| border-top-left-radius: 3px; | |
| border-top-right-radius: 3px; | |
| border-bottom: none; | |
| flex-wrap: wrap; | |
| ${landscapeStyle( | |
| () => | |
| css` | |
| display: none; | |
| ` | |
| )} | |
| display: flex; | |
| justify-content: space-between; | |
| width: 100%; | |
| background-color: ${({ theme }) => theme.lightBlue}; | |
| padding: 24px; | |
| border 1px solid ${({ theme }) => theme.stroke}; | |
| border-top-left-radius: 3px; | |
| border-top-right-radius: 3px; | |
| border-bottom: none; | |
| flex-wrap: wrap; | |
| ${landscapeStyle(() => css` | |
| display: none; | |
| `)} |
There was a problem hiding this comment.
Let's move WithHelpTooltip to the components folder (since it's being used outside of pages/Dashboard
Comment on lines
23
to
24
| min-content repeat(2, calc(80px + (200 - 60) * (min(max(100vw, 375px), 1250px) - 375px) / 875)) | ||
| min-content auto; |
There was a problem hiding this comment.
Let's try and center total rewards and coherent votes
|
Kudos, SonarCloud Quality Gate passed!
|
|
Code Climate has analyzed commit 517b1d0 and detected 5 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on refactoring and reorganizing the code related to the Top Jurors feature on the Home page.
Detailed summary: