Skip to content
This repository was archived by the owner on Feb 7, 2022. It is now read-only.

Remove no longer used toggle attribute #17

Closed
wants to merge 1 commit into from
Closed

Remove no longer used toggle attribute #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/exercises-final/05.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ class Toggle extends React.Component {
getStateAndHelpers() {
return {
on: this.state.on,
toggle: this.toggle,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still useful in some situations, so I definitely suggest continuing to expose this. Remember that prop getters are just helpers and should generally not be the only way to accomplish certain tasks :) Thanks anyway!

togglerProps: {
'aria-expanded': this.state.on,
onClick: this.toggle,
Expand Down