This repository was archived by the owner on Feb 7, 2022. It is now read-only.
Remove no longer used toggle attribute #17
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
=======================================
Coverage 90.77% 90.77%
=======================================
Files 14 14
Lines 336 336
Branches 72 72
=======================================
Hits 305 305
Misses 21 21
Partials 10 10
Continue to review full report at Codecov.
|
kentcdodds
reviewed
Apr 17, 2018
| @@ -13,7 +13,6 @@ class Toggle extends React.Component { | |||
| getStateAndHelpers() { | |||
| return { | |||
| on: this.state.on, | |||
| toggle: this.toggle, | |||
There was a problem hiding this comment.
This is still useful in some situations, so I definitely suggest continuing to expose this. Remember that prop getters are just helpers and should generally not be the only way to accomplish certain tasks :) Thanks anyway!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.