Use underscore's isEqual to compare objects for equality #996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or equality. This is more robust than JSON.stringifying both operands, because the order of keys is relevant for JSON.stringify, but not for object equality. This led to 'false positive' inequality reports, which led to notebooks being set to dirty immediately after opening, which caused an autosave directly after load, which is annoying when you want to navigate away quickly.
|
Beaten to the punch by #992, I'm afraid. ;-) |
|
Bonus: I think the patches might be character-identical. Clearly on the right track! |
|
Heh, exactly my thoughts! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more robust than JSON.stringifying both operands, because the order of keys is relevant for JSON.stringify, but not for object equality. This led to 'false positive' inequality reports, which led to notebooks being set to dirty immediately after opening, which caused an autosave directly after load, which is annoying when you want to navigate away quickly.