use _.isEqual to check for metadata changes #992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSON.stringifiy is unreliable because it is key-order sensitive
|
+1. Candidate for backport too. |
|
Neat find, +1 |
|
I forget, where is the backport script? I think it used to live in ipython/ipython/scripts, which lead me to look in jupyter/notebook/scripts, but I did not see it there. Does it live somewhere else? |
jdfreder
added a commit
that referenced
this pull request
Jan 25, 2016
use _.isEqual to check for metadata changes
|
Now... we wait to run the script and run it at once to do back ports in batch, right? |
minrk
added a commit
that referenced
this pull request
Feb 6, 2016
JSON.stringifiy is unreliable because it is key-order sensitive closes #964
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON.stringifiy is unreliable because it is key-order sensitive
closes #964