-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Upload #1509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload #1509
Conversation
|
@nsknojj you can update pull requests by continuing to push commits to your branch, you do not need to open new pull requests with every change. Following discussion from #1501, For 'big file' support, it should definitely be hooked up to the contents manager and use the same upload button that already exists. Uploading 'big' files shouldn't be different from smaller ones. |
| mainly to be overridden in profile/static/custom/custom.css | ||
| This will always be an empty file in IPython |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file needs to stay empty. If there is more CSS to include in this page, it should be added to static/tree/less/tree.less.
|
I've modify the UI to be the same as the original upload. |
| @@ -0,0 +1,1462 @@ | |||
| /* | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
External dependencies should not be included in this repo. If it is needed, it should be added as a dependency in bower.json and loaded with require.
|
I don't know how to pass the travis-ci build test while I add a new dependency "require(['jquery.fileupload'] )" in "tree/js/main.js". Test file: /home/travis/build/jupyter/notebook/notebook/tests/base/deprecated-require-paths.js
Page Error
Message: SyntaxError: Parse error
Call stack:
Page Error
Message: Error: Script error for "contents"
http://requirejs.org/docs/errors.html#scripterror
Call stack:
line 140 of static/components/requirejs/require.js in defaultOnError
line 544 of static/components/requirejs/require.js in onError
line 1735 of static/components/requirejs/require.js
Page Error
Message: Error: Script error for "jquery.fileupload"
http://requirejs.org/docs/errors.html#scripterror
Call stack:
line 140 of static/components/requirejs/require.js in defaultOnError
line 544 of static/components/requirejs/require.js in onError
line 1735 of static/components/requirejs/require.js
Timeout for http://localhost:8888/a@b/
Is the notebook server running? |
Merge branch 'master' of https://github.com/jupyter/notebook into upload
|
@nsknojj Anything I can do to help? |
|
@gnestor Sorry for poor English. |
@nsknojj I suggest that we close this PR and if the need for this feature still exists, follow @minrk's suggestion and use the contents manager. |
Add the big file upload function
Old pull request: 1501