Skip to content

Conversation

@nsknojj
Copy link

@nsknojj nsknojj commented Jun 3, 2016

Add the big file upload function
Old pull request: 1501

@minrk
Copy link
Member

minrk commented Jun 3, 2016

@nsknojj you can update pull requests by continuing to push commits to your branch, you do not need to open new pull requests with every change.

Following discussion from #1501, For 'big file' support, it should definitely be hooked up to the contents manager and use the same upload button that already exists. Uploading 'big' files shouldn't be different from smaller ones.

mainly to be overridden in profile/static/custom/custom.css
This will always be an empty file in IPython
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file needs to stay empty. If there is more CSS to include in this page, it should be added to static/tree/less/tree.less.

@nsknojj
Copy link
Author

nsknojj commented Jun 8, 2016

I've modify the UI to be the same as the original upload.

@@ -0,0 +1,1462 @@
/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

External dependencies should not be included in this repo. If it is needed, it should be added as a dependency in bower.json and loaded with require.

@nsknojj
Copy link
Author

nsknojj commented Jun 11, 2016

I don't know how to pass the travis-ci build test while I add a new dependency "require(['jquery.fileupload'] )" in "tree/js/main.js".
I add the path of jquery-file-upload by using require.config({paths:{... : ...}}) in "templates/page.html"
But the error report says like this, and I don't know how to solve it.

Test file: /home/travis/build/jupyter/notebook/notebook/tests/base/deprecated-require-paths.js
Page Error
  Message:   SyntaxError: Parse error
  Call stack:
Page Error
  Message:   Error: Script error for "contents"
             http://requirejs.org/docs/errors.html#scripterror
  Call stack:
    line 140 of static/components/requirejs/require.js in defaultOnError
    line 544 of static/components/requirejs/require.js in onError
    line 1735 of static/components/requirejs/require.js
Page Error
  Message:   Error: Script error for "jquery.fileupload"
             http://requirejs.org/docs/errors.html#scripterror
  Call stack:
    line 140 of static/components/requirejs/require.js in defaultOnError
    line 544 of static/components/requirejs/require.js in onError
    line 1735 of static/components/requirejs/require.js
Timeout for http://localhost:8888/a@b/
Is the notebook server running?

@gnestor
Copy link
Contributor

gnestor commented Aug 11, 2016

@nsknojj Anything I can do to help?

@nsknojj
Copy link
Author

nsknojj commented Aug 11, 2016

@gnestor
I tried to add big file upload feature using thie existing plugin "blueimp-file-upload" https://github.com/blueimp/jQuery-File-Upload
In this commit, the travis ci build did not raise error, because I add the blueimp-file-upload javascript as an internal file instead of using bower to maintain the dependency.
Frankly, I'm not familiar with web, JS, CSS, BOWER and such things and I'm busy recently. If you want to continue completing this feature, you can make changes on my version, start your owns or whatever you can do. Thank you for attention and help!

Sorry for poor English.

@gnestor
Copy link
Contributor

gnestor commented Sep 12, 2016

Following discussion from #1501, For 'big file' support, it should definitely be hooked up to the contents manager and use the same upload button that already exists. Uploading 'big' files shouldn't be different from smaller ones.

@nsknojj I suggest that we close this PR and if the need for this feature still exists, follow @minrk's suggestion and use the contents manager.

@nsknojj nsknojj closed this Sep 19, 2016
@minrk minrk modified the milestone: no action Nov 23, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants