Skip to content

Conversation

@nsknojj
Copy link

@nsknojj nsknojj commented May 31, 2016

Add jquery-file-upload module, can upload big files.

@@ -0,0 +1,199 @@
{% extends "page.html" %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you didn't actuall mean to commit this file

@minrk
Copy link
Member

minrk commented May 31, 2016

You may also want to look at #536, which is a partial implementation chunked-file upload, which talks to the contents service. We will need to store files via the contents service and not force it to be on the local filesystem.

@nsknojj
Copy link
Author

nsknojj commented Jun 2, 2016

Hi, @minrk . Sorry for replying you so late. Before I change the structure of the code, I want to know your idea about the big file upload function.
I add an additional upload button, and the only function is to upload files, not related with saving files. Current design is a little different to the default upload button.
When you choose a set of files and click "open", these files will start uploading immediately, there is no "start" button (though it can be added).
Moreover, when an upload is done, the item bar will not destroy. Instead, I added a "Hide" button for user.

  1. Do you think if I need to follow the default upload's logic?
  2. Should I just leave one button for upload?
    updemo

@takluyver
Copy link
Member

From a UX point of view, if we do this, we'll definitely want to have just one upload button - users shouldn't have to decide whether an upload is 'big'. I'll leave it to Min and others whether this and/or #536 make sense.

@nsknojj nsknojj closed this Jun 3, 2016
@nsknojj nsknojj mentioned this pull request Jun 3, 2016
@minrk minrk added this to the no action milestone Jun 3, 2016
@daniel1124
Copy link

We have solved the problem of loading large files by chunking.
I would be happy to contribute the code. Please let me know what's the process. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants