Prepare for jupyter_client 7.0 #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbrochart
force-pushed
the
jupyter_client
branch
from
5537672 to
0c7aca0
Compare
|
With this we should be ready for jupyter_client 7.0. |
Carreau
reviewed
Sep 14, 2021
Co-authored-by: Matthias Bussonnier <[email protected]>
|
With |
|
Should be okay now. |
MSeal
approved these changes
Nov 14, 2021
This was referenced Nov 18, 2021
matthew-brett
added a commit
to matthew-brett/rnbgrader
that referenced
this pull request
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jupyter_console seems to directly use jupyter_client's
ZMQSocketChannel's methods through aKernelClient, instead of e.g.BlockingKernelClient. These methods are now async in jupyter_client master (and in the next 7.0 release). One option is to wrap each of these method calls withrun_sync.I've done this change so that it fixes jupyter/jupyter_client#653, but there might be other places where this is needed.