Skip to content

Conversation

@davidbrochart
Copy link
Member

@davidbrochart davidbrochart commented Aug 3, 2021

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks David - this LGTM. Since this, if I'm understanding things correctly, re-introduces the reasons for the 6.x releases getting yanked from PyPi, is there anything clients need to do differently with 7.0? If so, could you please jot down some notes in #671 that we'll gather into the release notes?

@davidbrochart
Copy link
Member Author

is there anything clients need to do differently with 7.0?

Yes, they need to replace block=False with timeout=0.

If so, could you please jot down some notes in #671 that we'll gather into the release notes?

I guess you meant #642. If so, sure I will do it.

@kevin-bates
Copy link
Member

I guess you meant #642. If so, sure I will do it.

Yep - sorry about that. 😄. Thank you for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants