Fix conic error #284
Merged
Fix conic error #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [docs] update to Documenter@1 * Update
andrewrosemberg
commented
Apr 12, 2025
Comment on lines
+136
to
+138
| # FIXME: this is not working - https://github.com/jump-dev/DiffOpt.jl/issues/283 | ||
| # @test JuMP.coefficient(MOI.get(model, DiffOpt.ReverseConstraintFunction(), csoc).func.func.func, t.index) ≈ ds atol=ATOL rtol=RTOL | ||
|
|
Member
There was a problem hiding this comment.
this will be left open for a future PR
andrewrosemberg
commented
Apr 12, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## jg/jumpapi #284 +/- ##
==============================================
+ Coverage 89.08% 89.43% +0.35%
==============================================
Files 15 16 +1
Lines 1969 1997 +28
==============================================
+ Hits 1754 1786 +32
+ Misses 215 211 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* Pass attributes through Objective.FunctionConversionBridge * Fix * add test * fix tol * fix test * add reverse test --------- Co-authored-by: joaquimg <[email protected]>
andrewrosemberg
added a commit
that referenced
this pull request
Aug 20, 2025
* fix conic error * use jump psd problem * [docs] update to Documenter@1 (#286) * [docs] update to Documenter@1 * Update * update * format * Pass attributes through Objective.FunctionConversionBridge (#287) * Pass attributes through Objective.FunctionConversionBridge * Fix * add test * fix tol * fix test * add reverse test --------- Co-authored-by: joaquimg <[email protected]> * bump POI * cleanup --------- Co-authored-by: Oscar Dowson <[email protected]> Co-authored-by: Benoît Legat <[email protected]> Co-authored-by: joaquimg <[email protected]>
joaquimg
added a commit
that referenced
this pull request
Aug 20, 2025
* initial sketch * rm method * add JuMP API and test it * add diff_model test * Fix conic error (#284) * fix conic error * use jump psd problem * [docs] update to Documenter@1 (#286) * [docs] update to Documenter@1 * Update * update * format * Pass attributes through Objective.FunctionConversionBridge (#287) * Pass attributes through Objective.FunctionConversionBridge * Fix * add test * fix tol * fix test * add reverse test --------- Co-authored-by: joaquimg <[email protected]> * bump POI * cleanup --------- Co-authored-by: Oscar Dowson <[email protected]> Co-authored-by: Benoît Legat <[email protected]> Co-authored-by: joaquimg <[email protected]> * fix parameters support * Update jump-api pr (#294) * prepare more tests * sketch * temp examples * remove printing * remove printing * remove duplicatie def * move definition * format * format * simplify conic model * force nlp on nlp tests * fix param tests * cleanup parameter usage * remove code * cleanup usage of parameters * format * add temp dep * format * add temp dep * fix PSDSquare * temp fix for tests * format * Improve name handling, cleanup parameter error messages, remove slack * re-enable constraint names * Integrate new POI (#302) * integrate new POI * remove test * rm adhoc pkg add * fix docs * add POI test and docs * rm test_solve_conflict * format * add parameter in cone test * add back name constraint vect * Update Project.toml --------- Co-authored-by: Joaquim <[email protected]> * add tests * format --------- Co-authored-by: Andrew Rosemberg <[email protected]> Co-authored-by: Oscar Dowson <[email protected]> Co-authored-by: Benoît Legat <[email protected]>
joaquimg
added a commit
that referenced
this pull request
Sep 22, 2025
* implement dual of parameter anywhere * fix api and more tests * format * update docs * update for appropriate API * update documemtation * format * rm legacy function * rm unecessary functions * read necessary functions * Update DiffOpt.jl * fix bug indexing * format * initial sketch * rm method * add JuMP API and test it * add diff_model test * Fix conic error (#284) * fix conic error * use jump psd problem * [docs] update to Documenter@1 (#286) * [docs] update to Documenter@1 * Update * update * format * Pass attributes through Objective.FunctionConversionBridge (#287) * Pass attributes through Objective.FunctionConversionBridge * Fix * add test * fix tol * fix test * add reverse test --------- Co-authored-by: joaquimg <[email protected]> * bump POI * cleanup --------- Co-authored-by: Oscar Dowson <[email protected]> Co-authored-by: Benoît Legat <[email protected]> Co-authored-by: joaquimg <[email protected]> * fix parameters support * Update jump-api pr (#294) * prepare more tests * sketch * temp examples * remove printing * remove printing * remove duplicatie def * move definition * format * format * simplify conic model * force nlp on nlp tests * fix param tests * cleanup parameter usage * remove code * cleanup usage of parameters * format * add temp dep * format * add temp dep * fix PSDSquare * temp fix for tests * format * Improve name handling, cleanup parameter error messages, remove slack * re-enable constraint names * integrate new POI * remove test * rm adhoc pkg add * fix docs * add POI test and docs * rm test_solve_conflict * format * add parameter in cone test * add back name constraint vect * Update Project.toml * implement dual of parameter anywhere * update for appropriate API * format * fix * fix docs * add error for non implemented backends * fix error handeling * format * fix tests * fix tests * format * improve coverage * format * bump version * update docs * udpate docs * fix error dual objective sensitivity mention * format * fix typo * fix typo * Update docs/src/usage.md Co-authored-by: Benoît Legat <[email protected]> * Apply suggestion from @andrewrosemberg * pin MLDatasets * Apply suggestion from @joaquimg Co-authored-by: Joaquim <[email protected]> * Apply suggestion from @joaquimg Co-authored-by: Joaquim <[email protected]> * Apply suggestion from @joaquimg Co-authored-by: Joaquim <[email protected]> * Apply suggestion from @andrewrosemberg * Apply suggestion from @andrewrosemberg * Apply suggestion from @andrewrosemberg * Apply suggestion from @andrewrosemberg * rename objective_sensitivity_p * fix tests * update tests * format * rm dual and addition overloads --------- Co-authored-by: joaquimg <[email protected]> Co-authored-by: Oscar Dowson <[email protected]> Co-authored-by: Benoît Legat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the bug in the conic formulation in which forward sensitivities with LHS have flipped the sign.
Related to how the
dAmatrix of sensitivities is used.TODO:
ReverseConstraintFunctionfor Conic Constraints #283DiffOpt.forward_differentiate!from PSD Conic JuMP problems #285