-
Notifications
You must be signed in to change notification settings - Fork 15
Add JuMP-like API #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JuMP-like API #281
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #281 +/- ##
==========================================
- Coverage 89.20% 89.01% -0.20%
==========================================
Files 15 16 +1
Lines 1973 2057 +84
==========================================
+ Hits 1760 1831 +71
- Misses 213 226 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* fix conic error * use jump psd problem * [docs] update to Documenter@1 (#286) * [docs] update to Documenter@1 * Update * update * format * Pass attributes through Objective.FunctionConversionBridge (#287) * Pass attributes through Objective.FunctionConversionBridge * Fix * add test * fix tol * fix test * add reverse test --------- Co-authored-by: joaquimg <[email protected]> * bump POI * cleanup --------- Co-authored-by: Oscar Dowson <[email protected]> Co-authored-by: Benoît Legat <[email protected]> Co-authored-by: joaquimg <[email protected]>
* prepare more tests * sketch * temp examples * remove printing * remove printing * remove duplicatie def * move definition * format * format * simplify conic model * force nlp on nlp tests * fix param tests * cleanup parameter usage * remove code * cleanup usage of parameters * format * add temp dep * format * add temp dep * fix PSDSquare * temp fix for tests * format
| # TODO check ci.value's | ||
| idx = model.cache.dual_mapping[ci.value] | ||
| return model.forw_grad_cache.dual_Δs[idx] | ||
| catch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrewrosemberg , this way of getting the map does not seem to match perfectly with the one below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My logic was:
dual_Δsis indexed by NLP model constraint index, so we need to go from MOI to NLP usingdual_mapping- In the one below
Δpis indexed my NLP Parameter index, so we need to go from MOI variable index to NLP parameter index, thus the use ofvar2param
* integrate new POI * remove test * rm adhoc pkg add * fix docs * add POI test and docs * rm test_solve_conflict * format * add parameter in cone test * add back name constraint vect * Update Project.toml --------- Co-authored-by: Joaquim <[email protected]>
closes #271