Skip to content

Conversation

@joaquimg
Copy link
Member

@joaquimg joaquimg commented Feb 22, 2025

closes #271

@codecov
Copy link

codecov bot commented Feb 22, 2025

Codecov Report

❌ Patch coverage is 92.06349% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.01%. Comparing base (2d346bb) to head (3d9ca1f).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/diff_opt.jl 81.81% 4 Missing ⚠️
src/moi_wrapper.jl 92.59% 4 Missing ⚠️
src/ConicProgram/ConicProgram.jl 85.71% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
- Coverage   89.20%   89.01%   -0.20%     
==========================================
  Files          15       16       +1     
  Lines        1973     2057      +84     
==========================================
+ Hits         1760     1831      +71     
- Misses        213      226      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

andrewrosemberg and others added 2 commits May 19, 2025 22:57
* fix conic error

* use jump psd problem

* [docs] update to Documenter@1 (#286)

* [docs] update to Documenter@1

* Update

* update

* format

* Pass attributes through Objective.FunctionConversionBridge (#287)

* Pass attributes through Objective.FunctionConversionBridge

* Fix

* add test

* fix tol

* fix test

* add reverse test

---------

Co-authored-by: joaquimg <[email protected]>

* bump POI

* cleanup

---------

Co-authored-by: Oscar Dowson <[email protected]>
Co-authored-by: Benoît Legat <[email protected]>
Co-authored-by: joaquimg <[email protected]>
* prepare more tests

* sketch

* temp examples

* remove printing

* remove printing

* remove duplicatie def

* move definition

* format

* format

* simplify conic model

* force nlp on nlp tests

* fix param tests

* cleanup parameter usage

* remove code

* cleanup usage of parameters

* format

* add temp dep

* format

* add temp dep

* fix PSDSquare

* temp fix for tests

* format
Comment on lines +610 to 613
# TODO check ci.value's
idx = model.cache.dual_mapping[ci.value]
return model.forw_grad_cache.dual_Δs[idx]
catch
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewrosemberg , this way of getting the map does not seem to match perfectly with the one below

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My logic was:

  • dual_Δs is indexed by NLP model constraint index, so we need to go from MOI to NLP using dual_mapping
  • In the one below Δp is indexed my NLP Parameter index, so we need to go from MOI variable index to NLP parameter index, thus the use of var2param

andrewrosemberg and others added 2 commits August 19, 2025 21:30
* integrate new POI

* remove test

* rm adhoc pkg add

* fix docs

* add POI test and docs

* rm test_solve_conflict

* format

* add parameter in cone test

* add back name constraint vect

* Update Project.toml

---------

Co-authored-by: Joaquim <[email protected]>
@joaquimg joaquimg merged commit ad143a7 into master Aug 20, 2025
5 of 6 checks passed
@joaquimg joaquimg deleted the jg/jumpapi branch August 20, 2025 11:28
This was referenced Sep 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup error messages from parameters.jl Remove slack data from conic model Add a JuMP-like syntax to diff wrt parameters

4 participants