Skip to content

Conversation

@bbrala
Copy link
Contributor

@bbrala bbrala commented May 2, 2025

Add missing breaking change to upgrade guide

Fixes #822

Add missing breaking change to upgrade guide
@DannyvdSluijs DannyvdSluijs requested a review from Copilot May 2, 2025 14:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the UPGRADE-6.0.md upgrade guide by adding a missing section that details the breaking change in the signature of the BaseConstraint::addError method.

  • Adds documentation for the new method signature
  • Provides before/after code snippets to illustrate the changes

bbrala and others added 2 commits May 2, 2025 17:17
@bbrala
Copy link
Contributor Author

bbrala commented May 2, 2025

Thanks copilot

@DannyvdSluijs
Copy link
Collaborator

@bbrala changes are okay. This PR is only missing an entry to the changelog. I can add one later this week and merge this pr. Thanks for the efforts.

@bbrala
Copy link
Contributor Author

bbrala commented May 5, 2025

Added changelog entry

@DannyvdSluijs DannyvdSluijs merged commit 708a160 into jsonrainbow:master May 5, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Breaking change missing in 5 to 6 upgrade

2 participants