Breaking change missing in 5 to 6 upgrade

[bbrala]

Seems the signature of BaseConstraint has changed:

public function addError(?JsonPointer $path, $message, $constraint = '', ?array $more = null)

public function addError(ConstraintError $constraint, ?JsonPointer $path = null, array $more = []): void

Is that intentional? Guess the fact it isn't optional anymore is the problem there.

[github-actions]

🚀 @bbrala, thanks for your contribution! Every idea, bug report, and discussion helps make this project better. Your input is invaluable, and we appreciate the time you took to share it. A maintainer will review it soon—stay awesome! 💡✨

⭐ Enjoying contributing? Star the project! ⭐Your contributions help this project grow, and we'd love your support in another way too! If you find this repo helpful, consider leaving a star 🌟 on GitHub.

[longwave]

This was done a very long time ago in #364

[longwave]

To be compatible with both versions we can perhaps use class_exists(ConstraintError::class) and call the relevant signature?

[DannyvdSluijs]

@bbrala perhaps you can elaborate on your issue? Breaking changes between mayor versions is possible.

I can see this was not covered in the upgrade guide. If this is your point, feel free to open PR and add the information.

[bbrala]

To be compatible with both versions we can perhaps use class_exists(ConstraintError::class) and call the relevant signature?

yes we can.

@bbrala perhaps you can elaborate on your issue? Breaking changes between mayor versions is possible.

I can see this was not covered in the upgrade guide. If this is your point, feel free to open PR and add the information.

Ok, will do.