Skip to content

allowing for extension of Scoping::Filter class #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richmolj merged 2 commits into from
Jun 4, 2018
Merged

allowing for extension of Scoping::Filter class #74

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a23f074
allowing for extension of Scoping::Filter class
amitsuryavanshi Apr 17, 2018
04c4de1
further refactoring on JsonapiCompliable::Scope#apply_scoping
amitsuryavanshi Jun 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions lib/jsonapi_compliable/scope.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,13 +91,17 @@ def sideload(results, includes)
end
end

def apply_scoping(opts)
@object = JsonapiCompliable::Scoping::DefaultFilter.new(@resource, query_hash, @object).apply
@object = JsonapiCompliable::Scoping::Filter.new(@resource, query_hash, @object).apply unless opts[:filter] == false
@object = JsonapiCompliable::Scoping::ExtraFields.new(@resource, query_hash, @object).apply unless opts[:extra_fields] == false
@object = JsonapiCompliable::Scoping::Sort.new(@resource, query_hash, @object).apply unless opts[:sort] == false
@unpaginated_object = @object
@object = JsonapiCompliable::Scoping::Paginate.new(@resource, query_hash, @object, default: opts[:default_paginate]).apply unless opts[:paginate] == false
def apply_scoping(opts)
add_scoping(nil, JsonapiCompliable::Scoping::DefaultFilter, opts)
add_scoping(:filter, JsonapiCompliable::Scoping::Filter, opts)
add_scoping(:extra_fields, JsonapiCompliable::Scoping::ExtraFields, opts)
add_scoping(:sort, JsonapiCompliable::Scoping::Sort, opts)
add_scoping(:paginate, JsonapiCompliable::Scoping::Paginate, opts, default: opts[:default_paginate])
end

def add_scoping(key, scoping_class, opts, default = {})
@object = scoping_class.new(@resource, query_hash, @object, default).apply unless opts[key] == false
@unpaginated_object = @object unless key == :paginate
end
end
end