Skip to content

Conversation

@amitsuryavanshi
Copy link
Contributor

@amitsuryavanshi amitsuryavanshi commented Apr 17, 2018

This change will allow someone to extend filtering classes like sonapiCompliable::Scoping::DefaultFilter, JsonapiCompliable::Scoping::Filter, JsonapiCompliable::Scoping::Sort, etc. for any additional or modified functionality.

@klobuczek
Copy link

klobuczek commented May 31, 2018

+1
I have had similar problem in the past. Sometimes it is difficult to extend jsonapi_suite. Without such a refactoring you have to duplicate the entire apply_scoping method and thus become much more fragile and missing future extensions.

@richmolj
Copy link
Contributor

What's an example of what you would do with a different filter class?

@amitsuryavanshi
Copy link
Contributor Author

@richmolj as per our discussion on slack, I have updated the PR. Thanks.

@richmolj richmolj merged commit 69e5b00 into jsonapi-suite:master Jun 4, 2018
@richmolj
Copy link
Contributor

richmolj commented Jun 4, 2018

Released in 0.11.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants