Skip to content

Add namedExamples #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Add namedExamples #1114

wants to merge 5 commits into from

Conversation

K-Adam
Copy link

@K-Adam K-Adam commented Jul 7, 2021

handrews and others added 5 commits May 13, 2021 12:37
This is covered for the entire spec as section 8.1.3.
Note that the validation spec also has this, but only once
in that document, so nothing else needs deleting.
…cess

Remove repetitiously redundant paragraphs
Vocabulary definitions need not be formal or published depending on usage.
Copy link
Member

@gregsdennis gregsdennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for preempting this change. I think that it needs a bit more discussion, though. We don't typically add keywords to the base schema lightly.

I'll leave further comments in the issue.

@handrews
Copy link
Contributor

Even if accepted, this also needs to be changed to target the draft-next branch rather than master.

@K-Adam
Copy link
Author

K-Adam commented Jul 13, 2021

@handrews The Guidelines for contributing mentioned, that "Pull requests should be made to master"

@handrews
Copy link
Contributor

@K-Adam oops, thanks, it's a recent change, forgot to update the file.

@K-Adam K-Adam changed the base branch from master to draft-next July 18, 2021 10:15
@K-Adam K-Adam closed this Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants