Skip to content

Document new branching process #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

handrews
Copy link
Contributor

In PR #1114 @K-Adam noted that we still were requesting PRs go to master. This updates CONTRIBUTING.md with the new process.

This is targeted at draft-next and we can cherry-pick merge it down to master to ensure it is in both places.

Copy link
Member

@Relequestual Relequestual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with the proviso that we keep the issue open, awaiting an ADR to be filed for this, which is blocked by me rolling out ADRs to other repos (issue in community repo).

@handrews
Copy link
Contributor Author

@Relequestual to be clear, you want this PR kept open? There isn't a issue for this, just the discussion. It seems odd to hold this based on a technical/process block when it is causing problems for potential contributors.

@Relequestual Relequestual merged commit 1ac6282 into json-schema-org:draft-next Aug 11, 2021
@Relequestual
Copy link
Member

OK, resolving the discussion (adding the resolved tag for now) should require an ADR be filed.

Cross referencing even though it's in the change: json-schema-org/community#7

jdesrosiers pushed a commit to jdesrosiers/json-schema-spec that referenced this pull request Jun 30, 2022
jdesrosiers pushed a commit that referenced this pull request Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants