Code

Fix exception propagation#1021

Code

Merged

maurei merged 7 commits intomasterjson-api-dotnet/JsonApiDotNetCore:masterfrom

fix-exception-propagationjson-api-dotnet/JsonApiDotNetCore:fix-exception-propagationCopy head branch name to clipboard

Jun 23, 2021

Commits

Commits on Jun 22, 2021

• The exception thrown and wrapped on SaveChanges failure was superseeded while disposing PlaceholderResourceCollector that threw too, resulting in a 500 error response. And it produced noisy logs in…

  Show description for d585893
  

  Bart Koelman

  committed
  d585893

  Copy full SHA for d585893

• Specified a FK in scenario of a required one-to-one relationship. Note that not specifying it results in EF Core configuring this relationship using an identifying FK on the dependent side (Shipmen…

  Show description for 5eae4e2
  

  maurei

  authored and

  Bart Koelman

  committed
  5eae4e2

  Copy full SHA for 5eae4e2

• Updated tests to cover for zero-or-one-to-one cases

  

  maurei

  authored and

  Bart Koelman

  committed
  04dac0e

  Copy full SHA for 04dac0e

• add comment explaining why this change was needed

  

  maurei

  authored and

  Bart Koelman

  committed
  8806a04

  Copy full SHA for 8806a04

• Clarified comment

  

  Bart Koelman

  committed
  0e9fcfc

  Copy full SHA for 0e9fcfc

• Verified existing one-to-one relationships in our codebase and updated to use an explicit foreign key accordingly. It turns out that not in all cases this makes a difference. I wonder under which c…

  Show description for 77be4ff
  

  Bart Koelman

  committed
  77be4ff

  Copy full SHA for 77be4ff

Commits on Jun 23, 2021

• Fixed missing body assertions

  

  Bart Koelman

  committed
  c38d223

  Copy full SHA for c38d223