Fix exception propagation #1021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed while disposing PlaceholderResourceCollector that threw too, resulting in a 500 error response. And it produced noisy logs in cibuild, coming from ExceptionHandler. This commit swallows the second exception so the original one can propagate through the pipeline as intended.
…e that not specifying it results in EF Core configuring this relationship using an identifying FK on the dependent side (Shipment), which is a type of modeling that does not make sense in the scope of JSON:API.
bart-degreed
force-pushed
the
fix-exception-propagation
branch
from
320eab6 to
451bb32
Compare
added 2 commits
June 23, 2021 00:32
…d to use an explicit foreign key accordingly. It turns out that not in all cases this makes a difference. I wonder under which circumstances EF Core chooses to use an identifying foreign key and when it does not.
bart-degreed
force-pushed
the
fix-exception-propagation
branch
from
8a68a7a to
77be4ff
Compare
|
I considered adding a note to our documentation on HasOne, but it's not entirely clear to me when EF Core chooses to create an identifying foreign key. It does not always do that (see commit details). One condition is that the primary keys of both resources must be of the same type, which usually is not the case in our examples. |
Codecov Report
@@ Coverage Diff @@
## master #1021 +/- ##
==========================================
- Coverage 91.49% 91.47% -0.03%
==========================================
Files 275 275
Lines 7668 7671 +3
==========================================
+ Hits 7016 7017 +1
- Misses 652 654 +2
Continue to review full report at Codecov.
|
maurei
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1017.