Fix "instanceof Error" #8220
Fix "instanceof Error" #8220
Conversation
|
You saved my life @gkubisa. Until this PR is merged, our tests will still work |
| return this === error | ||
| ? toString.call(potentialInstance) === '[object Error]' | ||
| : originalHasInstance.call(this, potentialInstance); |
There was a problem hiding this comment.
note: because jest supports node >= 10 now, I think that util.types.isNativeError would work. I did only some limited test and it worked for my small case.
|
This PR is stale because it has been open 1 year with no activity. Remove stale label or comment or this will be closed in 30 days. |
|
This PR was closed because it has been stalled for 30 days with no activity. Please open a new PR if the issue is still relevant, linking to this one. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
4 participants
Partially fixes #2549.
It fixes only
instanceof Errorand does not affectinstanceof AnySubClassOfErrornor any otherinstanceofusage. Because it is so specific, I don't think it is suitable for merging. #5995 would certainly be a better fix, if it worked.Comparing my fix and #5995, I think the problem might be that errors are somehow mishandled in
jestitself, which results in issues withinstanceof SubClassOfErrorchecks withinjest. Once those are fixed, #5995 should just work. Does it make sense?cc @SimenB