-
Notifications
You must be signed in to change notification settings - Fork 6.3k
feat(cli): add test for readSocketPath #4284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✨ Coder.com for PR #4284 deployed! It will be updated on every commit.
|
0626bce to
3afa0e2
Compare
e2a94c2 to
367ccc0
Compare
greyscaled
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️ looks good to me - just had a question about using a type predicate on ErrnoException
|
Waiting on #4290 |
3ae9355 to
fb7fd50
Compare
fb7fd50 to
9a39e54
Compare
9a39e54 to
ad379fb
Compare
Codecov Report
@@ Coverage Diff @@
## main #4284 +/- ##
==========================================
+ Coverage 66.21% 66.29% +0.08%
==========================================
Files 31 31
Lines 1619 1620 +1
Branches 316 316
==========================================
+ Hits 1072 1074 +2
+ Misses 469 468 -1
Partials 78 78
Continue to review full report at Codecov.
|
ad379fb to
703a502
Compare
This PR adds tests for
readSocketPath.TODOs
readSocketPathand exportreadSocketPathFixes N/A